pcurl command #109

VTopoliuk · 2015-09-08T12:40:19Z

Added ability to convert NSURLReuqest to curl command.
Example:

  NSMutableURLRequest *request = [[NSMutableURLRequest alloc] initWithURL:[NSURL URLWithString:@"https://google.com"]];
  request.timeoutInterval = 30;
  request.HTTPMethod = @"POST";
  request.allHTTPHeaderFields = @{@"Header1" : @"test-1", @"Header2" : @"some test sttring"};
  request.HTTPBody = [@"sample data" dataUsingEncoding:NSUTF8StringEncoding];

curl -X POST --connect-timeout 30 -H "Header2: some test sttring" -H "Header1: test-1" --data-binary @"/tmp/curl_data_463408775.11118102" "https://google.com"

Also you can embed data into terminal command with --embed-data parameter, result:

echo "c2FtcGxlIGRhdGE=" | base64 -D -o "/tmp/curl_data_463487823.35579801"; curl -X POST --connect-timeout 30 -H "Header2: some test sttring" -H "Header1: test-1" --data-binary @"/tmp/curl_data_463487823.35579801" "https://google.com"

Added ability to convert NSURLReuqest to curl command.

mattjgalloway · 2015-09-08T14:23:42Z

commands/FBPrintCommands.py

+  def run(self, arguments, options):
+    request = arguments[0]
+    HTTPHeaderSring = ''
+    HTTPMethod = fb.evaluateExpressionValue('(id)[{request} HTTPMethod]'.format(request=request)).GetObjectDescription()


I would prefer:

HTTPMethod = fb.evaluateExpressionValue("(id)[%s HTTPMethod]" % (request)).GetObjectDescription()

But then again, I ain't no Python guru.

IANAPG either, but I believe format is preferred over %. However, format does not require named args, so a middle ground is:

HTTPMethod = fb.evaluateExpressionValue('(id)[{} HTTPMethod]'.format(request)).GetObjectDescription()

EDIT: However there's a readability advantage to the way @VTopoliuk has it now.

mattjgalloway · 2015-09-08T14:26:07Z

Overall LGTM, sans the comments. @kastiglione - any thoughts before we merge?

arigrant · 2015-09-08T14:27:55Z

Looks great to me! I'll let @kastiglione take a peek as well though.

kastiglione · 2015-09-08T17:26:35Z

Great addition, thanks @VTopoliuk!

I think this just needs to error when run on device and is good to go.

VTopoliuk · 2015-09-09T10:46:57Z

I added --portable parameter to embed data into the final command. So now iOS Device is supported, but script will fire error if executed without --portable on device and request has body data.

mattjgalloway · 2015-09-09T11:27:12Z

commands/FBPrintCommands.py

+
+  def options(self):
+    return [
+      fb.FBCommandArgument(short='-p', long='--portable', arg='portable', boolean=True, default=False, help='Embed request data as base64.'),


Could this be useBase64Data or something? portable seems like a strange name for this parameter.

Or, just always do base64 data?

@mattjgalloway actually 'portable' in this case means portable command or "you can run this command on other computers, not current one only"
http://dictionary.reference.com/browse/portable

base64 looks ugly and contains overhead on every run, not sure always output it is a good option.

I don't get how 'portable' makes sense here still. It sort of makes sense, but not intuitive to me.

Since you're copy-pasting the curl command anyway, I don't see why it matters that the base64 is ugly.

In my real-life test base64 is longer than one screen

Ah ok. Big amounts of data!

I still do think that portable is a bad name. Maybe even it should be dataStyle and then options are tmp or base64 and it defaults to the one which makes most sense for the current platform.

Happy to see what @kastiglione / @arigrant think too.

"portable" is definitely opaque to me. I'm good with --base64. Other suggestions: --inline(-data), --embed(-data)…

VTopoliuk · 2015-09-10T18:28:50Z

I updated parameter name

mattjgalloway · 2015-09-11T09:23:11Z

@VTopoliuk How about the nit? Can you fix that and then I think we're good to go!

VTopoliuk · 2015-09-11T09:28:15Z

commands/FBPrintCommands.py

+    if len(HTTPHeaderSring) > 0:
+        commandString += ' ' + HTTPHeaderSring
+    if dataFile is not None:
+        commandString += ' --data-binary @"{}"'.format(dataFile)


@mattjgalloway actually same file are used in two cases:

To embed data

To write data to file

If I will place name generation under the not runtimeHelpers.isIOSDevice(): condition, then it will be not available here with --embed-data option.

Oh whoops sorry!

Should we go?

@kastiglione do you think it's ready for merge?

I left a couple comments. Primarily needs a fix for the location of dataFile.

Add print JSON command.

…r with logic and.

mattjgalloway · 2015-09-15T07:19:43Z

commands/FBPrintCommands.py

+          if fb.evaluateIntegerExpression('[{} respondsToSelector:@selector(base64EncodedStringWithOptions:)]'.format(HTTPData)):
+            dataAsString = fb.evaluateExpressionValue('(id)[(id){} base64EncodedStringWithOptions:0]'.format(HTTPData)).GetObjectDescription()
+        elif not runtimeHelpers.isIOSDevice():
+          fb.evaluateExpression('(BOOL)[{} writeToFile:@"{}" atomically:NO]'.format(HTTPData, dataFile))


It would be nice to at least warn if this fails.

Oh, you are totally right!

Prevent overly eager regex match in `fv` command

kastiglione · 2015-09-15T16:56:29Z

Looks like you'll need to merge master into this branch now.

Added ability to convert NSURLReuqest to curl command.

…r with logic and.

Conflicts: commands/FBPrintCommands.py

kastiglione · 2015-09-28T16:43:29Z

@VTopoliuk shall we merge this? cc @mattjgalloway

mattjgalloway · 2015-09-28T18:46:40Z

Let's do it.

pcurl command

Dave Lee and others added 2 commits June 2, 2015 09:59

Now with less greedy needles

61f5f2e

pcurl command

fe62a17

Added ability to convert NSURLReuqest to curl command.

facebook-github-bot added the CLA Signed label Sep 8, 2015

mattjgalloway reviewed Sep 8, 2015
View reviewed changes

Support iOS devices

707544b

mattjgalloway reviewed Sep 9, 2015
View reviewed changes

Update parameter name

1c5251d

VTopoliuk reviewed Sep 11, 2015
View reviewed changes

kastiglione and others added 2 commits September 11, 2015 22:49

Merge pull request facebook#111 from alexch2000/pjson

b0f477b

Add print JSON command.

Updated flag name in error description and replaced commands separato…

20d4d30

…r with logic and.

mattjgalloway reviewed Sep 15, 2015
View reviewed changes

mattjgalloway and others added 2 commits September 15, 2015 08:23

Merge pull request facebook#99 from facebook/fv-regex-fix

ed8ad40

Prevent overly eager regex match in `fv` command

Handling erros

01404de

Vitalii Topoliuk added 5 commits September 16, 2015 11:37

pcurl command

5e8151f

Added ability to convert NSURLReuqest to curl command.

Support iOS devices

cf290c4

Update parameter name

47c0273

Updated flag name in error description and replaced commands separato…

7ae3709

…r with logic and.

Handling erros

ca0f209

Vitalii Topoliuk added 2 commits September 16, 2015 11:38

Merge remote-tracking branch 'origin/pcurl' into pcurl

719f777

Conflicts: commands/FBPrintCommands.py

Fixing merge conflicts

a231b3b

kastiglione added a commit that referenced this pull request Sep 28, 2015

Merge pull request #109 from VTopoliuk/pcurl

033def7

pcurl command

kastiglione merged commit 033def7 into facebook:master Sep 28, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pcurl command #109

pcurl command #109

VTopoliuk commented Sep 8, 2015

mattjgalloway Sep 8, 2015

kastiglione Sep 8, 2015

mattjgalloway commented Sep 8, 2015

arigrant commented Sep 8, 2015

kastiglione commented Sep 8, 2015

VTopoliuk commented Sep 9, 2015

mattjgalloway Sep 9, 2015

VTopoliuk Sep 9, 2015

mattjgalloway Sep 9, 2015

VTopoliuk Sep 9, 2015

mattjgalloway Sep 9, 2015

mattjgalloway Sep 9, 2015

kastiglione Sep 9, 2015

VTopoliuk commented Sep 10, 2015

mattjgalloway commented Sep 11, 2015

VTopoliuk Sep 11, 2015

mattjgalloway Sep 11, 2015

VTopoliuk Sep 11, 2015

VTopoliuk Sep 11, 2015

kastiglione Sep 11, 2015

mattjgalloway Sep 15, 2015

VTopoliuk Sep 15, 2015

kastiglione commented Sep 15, 2015

kastiglione commented Sep 28, 2015

mattjgalloway commented Sep 28, 2015

pcurl command #109

pcurl command #109

Conversation

VTopoliuk commented Sep 8, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattjgalloway commented Sep 8, 2015

arigrant commented Sep 8, 2015

kastiglione commented Sep 8, 2015

VTopoliuk commented Sep 9, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VTopoliuk commented Sep 10, 2015

mattjgalloway commented Sep 11, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kastiglione commented Sep 15, 2015

kastiglione commented Sep 28, 2015

mattjgalloway commented Sep 28, 2015