Merged show{view,layer,image,imageref} into visualize #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I like this. Can you add updating the README to the diff please? @arigrant What do you think? |
|
@mattjgalloway Thanks for reminding me about it. |
| if fb.evaluateBooleanExpression('(BOOL)((unsigned long)CFGetTypeID((CFTypeRef)' + object + ') == (unsigned long)CGImageGetTypeID())'): | ||
| _showImage('(id)[UIImage imageWithCGImage:' + object + ']') | ||
| else: | ||
| comarisonStr = '(BOOL)[' + object + 'isKindOfClass:[{} class]]' |
There was a problem hiding this comment.
The (BOOL) cast is unnecessary with the use of evaluateBooleanExpression.
|
Thanks @antons 🔨 I have a couple comments, after that I'm 👍 |
|
@kastiglione Good idea about the error message. Nice to know |
| if fb.evaluateBooleanExpression('(unsigned long)CFGetTypeID((CFTypeRef)' + object + ') == (unsigned long)CGImageGetTypeID()'): | ||
| _showImage('(id)[UIImage imageWithCGImage:' + object + ']') | ||
| else: | ||
| isKindOfClassStr = '[' + object + 'isKindOfClass:[{} class]]' |
There was a problem hiding this comment.
Do you mind adding an NSObjectHelpers file and making an isKindOfClass method? Other than that I am so happy for this and totally psyched. Thanks for doing this!
|
Yeah! |
|
Looks good to me. Let's take it. Thanks! |
arigrant
added a commit
that referenced
this pull request
Mar 15, 2014
Merged show{view,layer,image,imageref} into visualize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #11 and #17, I merged
show{view,layer,image,image ref}intovisualize.