OS X Support (for major commands) #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arigrant
added a commit
that referenced
this pull request
Jul 9, 2014
OS X Support (for major commands)
|
Looks good to me! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the commands (afaik) don't have equivalents (such as getting the "key" window. You can't do that with Mac. Ever. And a lot of apps don't have a mainWindow assigned, so grabbing the first one in the -windows is a reasonable default.) This is true also in a more literal sense, as CARenderServer isn't really queryable (that I could find) like SpringBoard's is.
For the most part, it's just querying the architecture and replacing with NS* equivalents. Determining if the system is a Mac or not is done by attempting to grab the NSApplication* class. It doesn't exist on iOS.
The reason that the dynamic placeholders are used is that you can't query the target's architecture at lldb init, as there is no target. Thus, you can dynamic them and then assign them the real defaults at runtime.
The key changes hit are: