Implement pvc with +[UIViewController _printHierarchy] #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@a2 Wanna merge this? |
| @@ -103,6 +103,10 @@ def run(self, arguments, options): | |||
| isMac = runtimeHelpers.isMacintoshArch() | |||
|
|
|||
| if arguments[0] == '__keyWindow_rootVC_dynamic__': | |||
| if fb.evaluateBooleanExpression('[UIViewController respondsToSelector:@selector(_printHierarchy)]'): | |||
There was a problem hiding this comment.
Does @selector(_printHierarchy) work? Should we use NSSelectorFromString(@"_printHierarchy")?
There was a problem hiding this comment.
Yep, @selector has been working for me.
There was a problem hiding this comment.
It works at work. I'll try this on a new/empty project and confirm it works.
There was a problem hiding this comment.
Works as expected even in a brand spanking new app project.
a2
added a commit
that referenced
this pull request
Dec 17, 2014
Implement pvc with +[UIViewController _printHierarchy]
|
Thanks @a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives
pvca nice speed improvement.cc @a2 @arigrant