This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
implement pep-0394 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make it explicit that codemod needs python2, as it does not run with python3. according to pep-0394, python distributors are allowed to provide either python 2 or 3 as `python` command, and should provide `python2` and `python3` commands to refer to python v2 or 3 respectively. see http://www.python.org/dev/peps/pep-0394/ without this fix, codemod doesn't run on platforms where `python` is python3, such as Arch Linux
|
How hard is it to make it work with python 3? |
|
not sure, I have no interest in porting to python3 right now. |
|
can this be merged? it's still broken. |
|
Woah, @Dieterbe, sorry for the slow turnaround on this! 🙊 💦 This looks like a great change, thanks! |
|
blast from the past! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make it explicit that codemod needs python2,
as it does not run with python3.
according to pep-0394, python distributors are allowed to provide either
python 2 or 3 as
pythoncommand, and should providepython2andpython3commands to refer to python v2 or 3 respectively.see http://www.python.org/dev/peps/pep-0394/
without this fix, codemod doesn't run on platforms where
pythonispython3, such as Arch Linux