Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand CKComponentViewAttribute coverage #430

Merged
merged 2 commits into from Nov 25, 2015
Merged

Expand CKComponentViewAttribute coverage #430

merged 2 commits into from Nov 25, 2015

Conversation

dbworku
Copy link
Contributor

@dbworku dbworku commented Nov 25, 2015

Increased the coverage of CKComponentViewAttribute setter methods by adding:

  • Test all supported types in performSetter()
  • Direct testing of setting an attribute on the layer, of a component's view, with CKComponentViewAttribute::LayerAttribute().

@dbworku
Merge branch 'facebook/master'
1a20a59
@dbworku
Expand CKComponentViewAttribute coverage
4d8300d 
Expand CKComponentViewAttributeTest to cover:
- Conversion of NSNumber to all primitive numeric types
- CKComponentViewAttribute::LayerAttribute() setter function layer of
components view
@adamjernst
Copy link
Contributor

Pretty awesome, thanks!

adamjernst added a commit that referenced this pull request Nov 25, 2015
@adamjernst
Merge pull request #430 from dbworku/Expand-Test-Coverage
d3a1c82 
Expand CKComponentViewAttribute coverage
@adamjernst adamjernst merged commit d3a1c82 into facebook:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed GH Review: review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbworku @adamjernst @facebook-github-bot