Test class properties (#5183)

* Test flow types are stripped before class properties are transformed * Do not search multiple levels deep * Revert "Do not search multiple levels deep" This reverts commit 5b5324d. * Add missing file for test script to boot * Make sure src and node modules are ignored * Fix error * derp * fix test * Drop unneeded check
facebook · Oct 1, 2018 · 02b8c35 · 02b8c35
1 parent 3c70340
commit 02b8c35
Show file tree

Hide file tree

Showing 7 changed files with 54 additions and 1 deletion.
diff --git a/fixtures/smoke/issue-5176-flow-class-properties/index.test.js b/fixtures/smoke/issue-5176-flow-class-properties/index.test.js
@@ -0,0 +1,13 @@
+const { bootstrap, isSuccessfulTest } = require('../../utils');
+beforeEach(async () => {
+  await bootstrap({ directory: global.testDirectory, template: __dirname });
+});
+
+describe('issue #5176 (flow class properties interaction)', () => {
+  it('passes tests', async () => {
+    await isSuccessfulTest({
+      directory: global.testDirectory,
+      jestEnvironment: 'node',
+    });
+  });
+});
diff --git a/fixtures/smoke/issue-5176-flow-class-properties/package.json b/fixtures/smoke/issue-5176-flow-class-properties/package.json
@@ -0,0 +1 @@
+{}
diff --git a/fixtures/smoke/issue-5176-flow-class-properties/public/index.html b/fixtures/smoke/issue-5176-flow-class-properties/public/index.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+  <html lang="en">
+  <head>
+    <title>React App</title>
+  </head>
+  <body>
+    <div id="root"></div>
+  </body>
+</html>
diff --git a/fixtures/smoke/issue-5176-flow-class-properties/src/App.js b/fixtures/smoke/issue-5176-flow-class-properties/src/App.js
@@ -0,0 +1,11 @@
+class App {
+  constructor() {
+    this.foo = this.foo.bind(this);
+  }
+  foo: void => void;
+  foo() {
+    return 'bar';
+  }
+}
+
+export default App;
diff --git a/fixtures/smoke/issue-5176-flow-class-properties/src/App.test.js b/fixtures/smoke/issue-5176-flow-class-properties/src/App.test.js
@@ -0,0 +1,6 @@
+import App from './App';
+
+it('creates instance without', () => {
+  const app = new App();
+  expect(app.foo()).toBe('bar');
+});
diff --git a/fixtures/smoke/jest.config.js b/fixtures/smoke/jest.config.js
@@ -1,5 +1,6 @@
 module.exports = {
   testEnvironment: 'node',
   testMatch: ['**/*.test.js'],
+  testPathIgnorePatterns: ['/src/', 'node_modules'],
   setupTestFrameworkScriptFile: './setupSmokeTests.js',
 };
diff --git a/fixtures/utils.js b/fixtures/utils.js
@@ -14,7 +14,7 @@ async function bootstrap({ directory, template }) {
   );
   if (shouldInstallScripts) {
     const packageJson = fs.readJsonSync(path.join(directory, 'package.json'));
-    packageJson.dependencies = Object.assign(packageJson.dependencies, {
+    packageJson.dependencies = Object.assign({}, packageJson.dependencies, {
       'react-scripts': 'latest',
     });
     fs.writeJsonSync(path.join(directory, 'package.json'), packageJson);
@@ -67,6 +67,17 @@ async function isSuccessfulProduction({ directory }) {
   }
 }
 
+async function isSuccessfulTest({ directory, jestEnvironment = 'jsdom' }) {
+  await execa(
+    './node_modules/.bin/react-scripts',
+    ['test', '--env', jestEnvironment, '--ci'],
+    {
+      cwd: directory,
+      env: { CI: 'true' },
+    }
+  );
+}
+
 async function getOutputDevelopment({ directory, env = {} }) {
   try {
     const { stdout, stderr } = await execa(
@@ -128,6 +139,7 @@ module.exports = {
   bootstrap,
   isSuccessfulDevelopment,
   isSuccessfulProduction,
+  isSuccessfulTest,
   getOutputDevelopment,
   getOutputProduction,
 };