Turn on certain TypeScript options (#5607)

facebook · Oct 28, 2018 · 9747480 · 9747480
1 parent eca0ec0
commit 9747480
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 1 deletion.
diff --git a/packages/react-scripts/config/webpack.config.dev.js b/packages/react-scripts/config/webpack.config.dev.js
@@ -424,6 +424,14 @@ module.exports = {
         async: false,
         checkSyntacticErrors: true,
         tsconfig: paths.appTsConfig,
+        compilerOptions: {
+          module: 'esnext',
+          moduleResolution: 'node',
+          resolveJsonModule: true,
+          isolatedModules: true,
+          noEmit: true,
+          jsx: 'preserve',
+        },
         watch: paths.appSrc,
         silent: true,
         formatter: typescriptFormatter,

diff --git a/packages/react-scripts/config/webpack.config.prod.js b/packages/react-scripts/config/webpack.config.prod.js
@@ -544,6 +544,14 @@ module.exports = {
         async: false,
         checkSyntacticErrors: true,
         tsconfig: paths.appTsConfig,
+        compilerOptions: {
+          module: 'esnext',
+          moduleResolution: 'node',
+          resolveJsonModule: true,
+          isolatedModules: true,
+          noEmit: true,
+          jsx: 'preserve',
+        },
         watch: paths.appSrc,
         silent: true,
         formatter: typescriptFormatter,

diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json
@@ -45,7 +45,7 @@
     "eslint-plugin-jsx-a11y": "6.1.2",
     "eslint-plugin-react": "7.11.1",
     "file-loader": "2.0.0",
-    "fork-ts-checker-webpack-plugin-alt": "0.4.10",
+    "fork-ts-checker-webpack-plugin-alt": "0.4.14",
     "fs-extra": "7.0.0",
     "html-webpack-plugin": "4.0.0-alpha.2",
     "identity-obj-proxy": "3.0.0",

diff --git a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js
@@ -101,6 +101,7 @@ function verifyTypeScriptSetup() {
     forceConsistentCasingInFileNames: { suggested: true },
 
     // These values are required and cannot be changed by the user
+    // Keep this in sync with the webpack config
     module: {
       parsedValue: ts.ModuleKind.ESNext,
       value: 'esnext',