Remove unsupported TS options (#5609)

facebook · Oct 28, 2018 · a958224 · a958224
1 parent 3403f05
commit a958224
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js b/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js
@@ -120,6 +120,13 @@ function verifyTypeScriptSetup() {
       value: 'preserve',
       reason: 'JSX is compiled by Babel',
     },
+    // We do not support absolute imports, though this may come as a future
+    // enhancement
+    baseUrl: {
+      value: undefined,
+      reason: 'absolute imports are not supported (yet)',
+    },
+    paths: { value: undefined, reason: 'aliased imports are not supported' },
   };
 
   const formatDiagnosticHost = {
@@ -184,22 +191,23 @@ function verifyTypeScriptSetup() {
     const { parsedValue, value, suggested, reason } = compilerOptions[option];
 
     const valueToCheck = parsedValue === undefined ? value : parsedValue;
+    const coloredOption = chalk.cyan('compilerOptions.' + option);
 
     if (suggested != null) {
       if (parsedCompilerOptions[option] === undefined) {
         appTsConfig.compilerOptions[option] = suggested;
         messages.push(
-          `${chalk.cyan('compilerOptions.' + option)} to be ${chalk.bold(
+          `${coloredOption} to be ${chalk.bold(
             'suggested'
           )} value: ${chalk.cyan.bold(suggested)} (this can be changed)`
         );
       }
     } else if (parsedCompilerOptions[option] !== valueToCheck) {
       appTsConfig.compilerOptions[option] = value;
       messages.push(
-        `${chalk.cyan('compilerOptions.' + option)} ${chalk.bold(
-          'must'
-        )} be ${chalk.cyan.bold(value)}` +
+        `${coloredOption} ${chalk.bold(
+          valueToCheck == null ? 'must not' : 'must'
+        )} be ${valueToCheck == null ? 'set' : chalk.cyan.bold(value)}` +
           (reason != null ? ` (${reason})` : '')
       );
     }