Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Path module in webpack config is not used after eject #1174

Closed
harunhasdal opened this issue Dec 6, 2016 · 2 comments
Closed

Path module in webpack config is not used after eject #1174

harunhasdal opened this issue Dec 6, 2016 · 2 comments
Labels
issue: bug

Comments

@harunhasdal
Copy link
Contributor

Nodejs path module is not used in webpack.config.dev.js and webpack.config.prod.js after ejecting.

This results in ESLint warning for no-unused-var rule.
@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

Would you like to fix it? You can wrap its import in // @remove-on-eject-begin and // @remove-on-eject-end.

@harunhasdal
Copy link
Contributor Author

Sure, creating a PR now.

harunhasdal pushed a commit to harunhasdal/create-react-app that referenced this issue Dec 6, 2016
Remove path module from webpack config on eject.
a438f17 
Fixes facebook#1174
@harunhasdal harunhasdal mentioned this issue Dec 6, 2016
Merged
harunhasdal pushed a commit to harunhasdal/create-react-app that referenced this issue Dec 6, 2016
Move path module inclusion right after the other imports
5cc329d 
Re: facebook#1174
gaearon pushed a commit that referenced this issue Dec 6, 2016
@harunhasdal @gaearon
Remove path module from webpack config on eject. (#1175)
8076567 
* Remove path module from webpack config on eject.

Fixes #1174

* Move path module inclusion right after the other imports

Re: #1174
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this issue Jan 23, 2017
@harunhasdal @alexdriaguine
Remove path module from webpack config on eject. (facebook#1175)
13067b5 
* Remove path module from webpack config on eject.

Fixes facebook#1174

* Move path module inclusion right after the other imports

Re: facebook#1174
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this issue May 8, 2017
@harunhasdal @randycoulman
Remove path module from webpack config on eject. (facebook#1175)
6df9012 
* Remove path module from webpack config on eject.

Fixes facebook#1174

* Move path module inclusion right after the other imports

Re: facebook#1174
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @harunhasdal