Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to run codemods #13

Closed
gaearon opened this issue Jul 17, 2016 · 13 comments
Closed

Provide a way to run codemods #13

gaearon opened this issue Jul 17, 2016 · 13 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Jul 17, 2016

I feel like this could be a nice way to introduce people to the idea of codemods. Many people don't know about https://github.com/reactjs/react-codemod or think running it is complicated. Maybe providing something like npm run upgrade-to-react-16 would be helpful. (Just throwing this idea out there.)

@lacker
Copy link
Contributor

lacker commented Jul 18, 2016

For codemodding itself I like it. I wonder about npm run codemode-foo though. Is the idea to provide more and more tools available via npm run blahblah in the autocreated project over time? It might be nicer to provide some dev tool that had stuff like the "start" and "build" functionality in it, and you could actually keep that tool as a dev dependency while developing. That way, if you had an old project you could upgrade your version of the toolkit.

Like, would npm run upgrade-to-react-16 only be available for projects created after the upgrade-to-react-16 codemod was created? That is sort of not the target audience.

@kentcdodds
Copy link
Contributor

Might be a place to consider p-s where scripts can be dynamic and updated as people upgrade their projects to the new version of the CLI (without having to update a [growing] package.json scripts)

@gaearon
Copy link
Contributor Author

gaearon commented Jul 18, 2016

@lacker

Totally, we’d need to change how we use scripts for this.

Might be a place to consider p-s where scripts can be dynamic and updated as people upgrade their projects to the new version of the CLI (without having to update a [growing] package.json scripts)

👍

@lacker
Copy link
Contributor

lacker commented Jul 18, 2016

So if scripts starts to be useful scripts for different parts of your app's lifecycle, rather than just scripts to start your app up, maybe it would be more accurate to just call the module something like react-scripts. (Which is available afaict)

@lacker
Copy link
Contributor

lacker commented Jul 18, 2016

It might also be neat if there were scripts like install-redux,install-relay, install-jest. Those could do a bit of codemodding and some npm installing to automate common other ecosystem tools. Also just throwing the idea out there.

@gaearon
Copy link
Contributor Author

gaearon commented Jul 18, 2016

Agreed that one script is better (we can still do it btw, just need to change those commands to be a single bin entry point).

Something like install-relay is super interesting but I want this to be something considered for conceptual "v2". Right now the scope is limited to build tooling because even that will take a while to get right. Then we can think about runtime dependencies.

@lacker
Copy link
Contributor

lacker commented Jul 18, 2016

V2ing install-relay sounds good to me. There is still the question of the name of the dependent package - people are gonna run create-react-app once, but the dependency on what is currently create-react-app-scripts could remain while the app goes into production, new engineers join the team, etc. Let's name it non-create-specifically to keep options open. Thoughts on react-scripts or react-run? (I'll ditch that other react-run project in favor of create-react-app either way.)

@gaearon
Copy link
Contributor Author

gaearon commented Jul 18, 2016

react-scripts sounds nice, is it free?

@vjeux
Copy link
Contributor

vjeux commented Jul 18, 2016

react-scripts not found :)

@vjeux
Copy link
Contributor

vjeux commented Jul 18, 2016

Let me codemod everything to react-scripts in the repo while one of you grab the npm package

@vjeux
Copy link
Contributor

vjeux commented Jul 18, 2016

756ed3f

@vjeux
Copy link
Contributor

vjeux commented Jul 18, 2016

And I grabbed the npm module

@gaearon
Copy link
Contributor Author

gaearon commented Sep 3, 2016

I’m pretty sure we’ll want to do this at some point, but let’s wait for first codemod to turn up, and then think about it.

@gaearon gaearon closed this as completed Sep 3, 2016
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants