Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for enabling Flexbox 2009 #2248

Closed
oltodo opened this issue May 19, 2017 · 7 comments
Closed

Option for enabling Flexbox 2009 #2248

oltodo opened this issue May 19, 2017 · 7 comments
Milestone

Comments

@oltodo
Copy link

oltodo commented May 19, 2017

I'm working on a HbbTV app writing in React and built with Create React App. Many of terminals HbbTV compliant are not totally up to date with the last specifications. I currently use a Samsung TV that I recently bought and I can observe that display: flex property is not interpreted instead of display: -webkit-flex. I could solve this problem by adding this line on styles myself (or by downgrading to 0.9.5) but maybe it could be possible to simply enable Flexbox 2009 by adding an option.

What is your opinion?

@gaearon
Copy link
Contributor

gaearon commented May 19, 2017

I think we won’t be enabling it by default anymore—sorry.
Maintaining options is costly (they’re too easy to break).

In the future I think we’ll solve this by letting you specify the browserslist so you can adjust the default configuration via Autoprefixer's own mechanism.

@oltodo
Copy link
Author

oltodo commented May 19, 2017

When you say browserlist, are you talking about Autoprefixer's browsers option ?

@gaearon
Copy link
Contributor

gaearon commented May 19, 2017

Yep.

@gaearon
Copy link
Contributor

gaearon commented May 19, 2017

More specifically I meant that Autoprefixer has a feature that inspects package.json for this list. We plan to support something similar.

@gaearon gaearon added this to the 1.x milestone May 19, 2017
@oltodo
Copy link
Author

oltodo commented May 19, 2017

Ok nice! Thanks for your reply @gaearon.

@gaearon
Copy link
Contributor

gaearon commented May 19, 2017

Thanks for filing the issue.

cr101 added a commit to cr101/create-react-app that referenced this issue May 25, 2017
…he browserslist key in package.json which allows developers to set browsers list in queries like "Chrome >= 35", "Firefox >= 38" for both production and development. Autoprefixer which relies on Browserslist will find its config automatically. This PR fixes facebook#2248 and facebook#892
@gaearon
Copy link
Contributor

gaearon commented Jan 8, 2018

Closing in favor of #892.

@gaearon gaearon closed this as completed Jan 8, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.