Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: Don't collect code coverage from registerServiceWorker.js File #2507

Closed
wirmar opened this issue Jun 9, 2017 · 1 comment
Closed

Suggestion: Don't collect code coverage from registerServiceWorker.js File #2507

wirmar opened this issue Jun 9, 2017 · 1 comment

Comments

@wirmar
Copy link
Contributor

wirmar commented Jun 9, 2017

Currently coverage is collected for the registerServiceWorker.js File by default. However this code was not user generated. Maybe this File should be ignored by default? ("collectCoverageFrom": ["src/**/*.{js,jsx}", "!**/registerServiceWorker.js"])
@gaearon
Copy link
Contributor

gaearon commented Jun 22, 2017

I don't know. I think it's a slippery slope: src/index.js was also generated and also not covered. And I think it's fine. Chasing 100% coverage is usually a misleading goal, and I don't want to give people the feeling that we encourage that.

@gaearon gaearon closed this as completed Jun 22, 2017
@scottnath scottnath mentioned this issue Aug 9, 2017
Closed
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @wirmar