Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI passes while E2E aborted early #258

Closed
Jiansen opened this issue Jul 28, 2016 · 6 comments
Closed

CI passes while E2E aborted early #258

Jiansen opened this issue Jul 28, 2016 · 6 comments
Assignees

Comments

@Jiansen
Copy link
Contributor

Jiansen commented Jul 28, 2016

In PR #257 , CI build reports passing while not all tests are done. The console log is here (see line 171).

I will think about this problem while fixing the permission problem.

@mxstbr
Copy link
Contributor

mxstbr commented Jul 28, 2016

That's definitely a bug! Why did that exit on a 0 even though there was an error? /cc @vjeux

@vjeux
Copy link
Contributor

vjeux commented Jul 28, 2016

Two possible explanations.

  1. It turns out that we didn't forward the error code when doing npm run build, it has been fixed in Improve error handling within e2e.sh #244

  2. The shell error handling was refactored in Return proper exit code in bin/react-scripts via spawnSync (#252) #256 there may be a bug.

I have a meeting for the next hour but I'll look afterwards. Thanks for pinging me

@vjeux
Copy link
Contributor

vjeux commented Jul 28, 2016

Could you rebase and send a version that breaks? See if the problem still happens.

@Jiansen
Copy link
Contributor Author

Jiansen commented Jul 28, 2016

@vjeux , I will do it and report back.

@Jiansen
Copy link
Contributor Author

Jiansen commented Jul 28, 2016

It seems that #256 doesn't capture bugs like this.

I created a simplified branch and PR in my forked repo because we shall never merge this test PR into this repo.

Let me know if you'd like to suggest other tests.

gaearon added a commit that referenced this issue Jul 29, 2016
I think this should solve #258
@gaearon
Copy link
Contributor

gaearon commented Jul 29, 2016

I might have fixed this in 4d60f08.
Let’s see how it goes.

@gaearon gaearon closed this as completed Jul 29, 2016
@lock lock bot locked and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants