Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print process PID for running application #3106

Closed
Pajn opened this issue Sep 11, 2017 · 3 comments
Closed

Print process PID for running application #3106

Pajn opened this issue Sep 11, 2017 · 3 comments

Comments

@Pajn
Copy link
Contributor

Pajn commented Sep 11, 2017

Is this a bug report?

No, a feature request.

When something is detected as already running on a port, c-r-a prints a helpful message. However most of the time it's me that have not closed an earlier project and it looks like this:

Something is already running on port 3000. Probably:
  node scripts/start.js
  in /path/to/project

it would be helpful if the pid was printed as well so I could just shoot it down instead of trying to find an open terminal. This information is already known by the code so it would just need to be added to the output.

What do you think?

@Timer
Copy link
Contributor

Timer commented Sep 11, 2017

This seems reasonable to me.

Something like?

Something is already running on port 3000. Probably:
  node scripts/start.js (pid 1234)
  in /path/to/project

Would you like to make a PR?

@Pajn
Copy link
Contributor Author

Pajn commented Sep 11, 2017

Yes, that would be perfect. Will try to get time for a PR tomorrow

@Timer
Copy link
Contributor

Timer commented Sep 11, 2017

Great!

@Timer Timer changed the title Feature Request: Print pid when something is already running on a port Print process PID for running application Sep 11, 2017
Pajn added a commit to Pajn/create-react-app that referenced this issue Sep 14, 2017
@Timer Timer closed this as completed in 2cff8db Sep 16, 2017
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this issue Sep 24, 2017
thongdong7 pushed a commit to thongdong7/create-react-app that referenced this issue Sep 24, 2017
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this issue Sep 24, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants