Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation links on "Writing tests" does not link correctly #3291

Closed
TryingToImprove opened this issue Oct 17, 2017 · 3 comments
Closed

Documentation links on "Writing tests" does not link correctly #3291

TryingToImprove opened this issue Oct 17, 2017 · 3 comments

Comments

@TryingToImprove
Copy link

Is this a bug report?

Not sure

Environment

https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#writing-tests

Steps to Reproduce

Click on "extensively documented here" or "jest.fn() and expect(fn).toBeCalled()"

Expected Behavior

Navigate to correct page.
....I am not sure where it should link to

Actual Behavior

Redirect to a 404
@Timer
Copy link
Contributor

Timer commented Oct 17, 2017

Fixed. 😄

@Timer Timer closed this as completed Oct 17, 2017
Timer pushed a commit that referenced this issue Oct 17, 2017
@alexkrolick @Timer
Fix dead link to Jest "expect" docs (#3289)
2d0ef6a 
Closes #3291
@TryingToImprove
Copy link
Author

It is only the first link which is fixed 😶

datchley pushed a commit to Tandemly/create-react-app that referenced this issue Oct 17, 2017
@backstroke-bot @dmatchley
Update from upstream repo facebookincubator/create-react-app@master (#4)
0cbbf89 
* `react-error-overlay` has no dependencies now (facebook#3263)

* `react-error-overlay` has no dependencies now (it's bundled)

* Use babel 6 for now

* Add external links to deployment services (facebook#3265)

* Add warning when using `react-error-overlay` in production (facebook#3264)

* Add a warning when running minified

* Add more robust check

* Update index.js

* Use production React version for bundled overlay (facebook#3267)

* Use production React version

* We cannot strip our own checks if production

* Keep the sourcemap during minify

* Prevent devtools pollution

* Add some comments

* sigh

* Fix dead link to Jest "expect" docs (facebook#3289)

Closes facebook#3291
@Timer
Copy link
Contributor

Timer commented Oct 17, 2017

1a3017b 😄

zmitry pushed a commit to zmitry/create-react-app that referenced this issue Aug 14, 2018
@alexkrolick @Timer
Fix dead link to Jest "expect" docs (facebook#3289)
bee92db 
Closes facebook#3291
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Timer @TryingToImprove