-
-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsupported key testURL causes troubles for (non-root) sub applications. #3425
Comments
/cc @gaearon what do you think about this? |
I think we should fix it.. somehow :-) |
Should we set a default |
Sounds reasonable to me |
+1 for this fix. There is a strange thing: BrowserRouter doesn't fire such warning. But I need Router... |
I was able to get around this by just adding --testURL http://localhost/{variable} into my test script in package.json, ie: "test": "react-scripts-ts test --env=jsdom --watch --testURL http://localhost/foo" |
Thanks!!!! I've been looking everywhere for a way to change this configuration without having to extract create-react-app! |
Hey @fdc-viktor-luft, have you tried this with the latest version? If this is still an issue, can you open a new issue? Thanks. |
Oh. I totally forgot this issue. Yes, it works perfectly fine 😉 |
Is this a bug report?
Yes
Can you also reproduce the problem with npm 4.x?
Yes
Which terms did you search for in User Guide?
https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#configuration
Environment
node -v
: v8.6.0npm -v
: 5.3.0yarn --version
(if you use Yarn): 1.3.2npm ls react-scripts
(if you haven’t ejected): 1.0.12Then, specify:
Steps to Reproduce
Expected Behavior
I would expect that your "createJestConfig" allows also to override "testURL" property. Then I could override your static value "http://localhost" with "http://localhost/app" to resolve my problem. I do not want to eject and had to patch your "createJestConfig" by one line:
Actual Behavior
You do not allow to override the "testURL" property inside the package.json.
The text was updated successfully, but these errors were encountered: