Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt StandardJS #448

Closed
2 tasks
davidascher opened this issue Aug 15, 2016 · 3 comments
Closed
2 tasks

Adopt StandardJS #448

davidascher opened this issue Aug 15, 2016 · 3 comments

Comments

@davidascher
Copy link
Contributor

I've found StandardJS to be a godsend, because its strong opinions mean I don't have to have opinions about styling.

Given the ambition of this project to influence beginners, I would submit that StandardJS would be a great influence on new devs.

See http://standardjs.com/ for details.

Specifically, for this project, I think this would mean at least:

  • fixing the default code to use single-quoted strings and omit semicolons
  • including linting via standard as part of the on-change handling.

I expect discussion ;-)

@wdhorton
Copy link
Contributor

wdhorton commented Aug 15, 2016

Just because the project doesn't use StandardJS doesn't mean it doesn't have a standard style (and linting). This project's style guide was adapted from Airbnb's (see eslint-config-airbnb), which is a very popular choice among JS devs.

@gaearon
Copy link
Contributor

gaearon commented Aug 15, 2016

Hi, thanks for the suggestion. We’ve taken a slightly different stance on linting in this project.

We want to stay out of the semicolon debates. It’s fine if you care about enforcing style, and you can use StandardJS yourself in the created projects, but beginners will just be frustrated that the example they copy and pasted from StackOverflow emits 50 warnings. This will lead them to ignore warnings completely, which is not what we want to do.

We started with airbnb config at first but even that was too strict for our intended use case. So we removed all styling rules from it. Our guiding principle in Create React App is that a linting warning should point to a potential error in the majority of cases. This is why something like StandardJS will not work for us, as it has a different goal for linting.

@gaearon gaearon closed this as completed Aug 15, 2016
@davidascher
Copy link
Contributor Author

While I like StandardJS, I really appreciate the rationale given, it's very thoughtful. Thanks.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants