Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bit.ly links from template #5910

Open
iansu opened this issue Nov 27, 2018 · 13 comments
Open

Remove bit.ly links from template #5910

iansu opened this issue Nov 27, 2018 · 13 comments
Assignees
Projects
Milestone

Comments

@iansu
Copy link
Contributor

iansu commented Nov 27, 2018

We need to remove the bit.ly links from the template because they point to the old README. We need to decide what to replace them with though. We could pick a new URL shortner but we could wind up in this situation again. Some allow you to change link destinations but who would own that account?

Follow up to: #5808.
Related: #5536

@bondz
Copy link
Contributor

bondz commented Nov 27, 2018

As discussed in the previous thread. I prefer firebase page.link dynamic links which would generate shortened links like https://cra.page.link/docs and allows us change the target destination as well. I am open to transferring it to a maintainer once we agree on what to do.

@iansu
Copy link
Contributor Author

iansu commented Nov 27, 2018

I somehow missed that suggestion in the previous thread. Seems like an okay option. Depending on anything Google related long-term worries me a bit though.

What would be really great is if Docusaurus supported shortlinks/aliases and we could use those instead. That combined with a custom URL for Create React App would be really nice. Not sure how feasible that is though.

@bondz
Copy link
Contributor

bondz commented Nov 27, 2018

Docusaurus supporting this natively would be best and that could be taken upstream and would take a while if they decide to add that.

Thought of getting create-react.app and createreact.app but they are both taken.

@iansu
Copy link
Contributor Author

iansu commented Nov 27, 2018

Yeah, @Timer and I noticed createreact.app was taken. Sad that neither of them are being used. A bunch of other CRA related domains are also being squatted. 😞

@stale
Copy link

stale bot commented Dec 29, 2018

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 29, 2018
@petetnt
Copy link
Contributor

petetnt commented Dec 30, 2018

We could use Netlify's __redirects file to do the short links similar to @kentcdodds netlify-shortener

This would give us

  1. The benefit of already using Netlify for the docs builds
  2. Full control over the URLs

The usage is rather simple, a __redirects file in the root redirects (with 301s or 302) or rewrites relative and absolute URLs according to the specification that looks something like this:

/cra             /create-react-app
/cra2           /foobar 302
/fOb             https://facebook.github.io/create-react-app/docs/setting-up-your-editor
/google          https://www.google.com

only thing missing would be the domain name :)

@stale stale bot removed the stale label Dec 30, 2018
@iansu
Copy link
Contributor Author

iansu commented Dec 30, 2018

I think this is a pretty good option, provided we get our own domain name. It's nice to not be tied to any particular shortening service.

@stale
Copy link

stale bot commented Feb 7, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Feb 7, 2019
@iansu iansu removed the stale label Feb 7, 2019
@stale
Copy link

stale bot commented Mar 9, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale
Copy link

stale bot commented Apr 9, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@pimlottc-gov
Copy link

I appreciate the thoughtful discussion on a better long term solution, but in meantime, documentation links have broken for months.

Perhaps just create new bit.ly links for now and replace them with more durable links later?

@bugzpodder bugzpodder added this to the 3.1 milestone Jul 3, 2019
@iansu iansu added this to To do in v3.3 via automation Oct 23, 2019
@ianschmitz ianschmitz removed this from the 3.3 milestone Dec 5, 2019
@ianschmitz ianschmitz added this to the 3.4 milestone Dec 5, 2019
@iansu iansu modified the milestones: 3.4, 3.5 Feb 14, 2020
@nel417
Copy link

nel417 commented Feb 27, 2020

any action on this?

@mikeperrotta
Copy link

Just noticing the links are still old and wanted to echo @pimlottc-gov's comment. There's lots of very thoughtful discussion here, but it might be good to sub in a bit.ly link in the meantime if this isn't moving forward. Could be a case of perfect being the enemy of good.

@raix raix modified the milestones: 5.1, 5.x Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v3.3
  
To do
Development

No branches or pull requests

9 participants