-
-
Notifications
You must be signed in to change notification settings - Fork 26.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PUBLIC_URL is not the same as homepage, but only the pathname #8813
Comments
Does anyone have a fix for this other than changing version to react-scripts@3.3.0? I changed the version and it created an issue as follows: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined Found the fix. Changed react-dev-utils to 10.1.0 |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Bumping this to prevent the stalebot from closing it. This is still a relevant issue. #7259 accidentally introduced a breaking change into v3.4.0 |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
I’ll see if I can find some time soon to take a look at this. Hopefully
it’s not a huge code change and it would be nice to get this fixed.
…On Thu, Jun 25, 2020 at 22:30 stale[bot] ***@***.***> wrote:
This issue has been automatically marked as stale because it has not had
any recent activity. It will be closed in 5 days if no further activity
occurs.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8813 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUP7BUXP4VFLN6OPV2GSTRYQW6VANCNFSM4MEXBMDA>
.
|
Just ran into this too. |
Ran into this as well - trying to host multiple react sites under a single domain \(〇_o)/ |
Having the same issue here.. any update? |
Appreciate you sharing this but it did not work for me.. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Bump - this is still an issue. I'll try to find time to look into this soon. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
hi. |
I fixed a similar error by setting the
Before I did that I was getting the app initialised locally with unwanted URL, something like:
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
I'll try to remember to update my PR since I'm sure there are conflicts by now, but I don't think anyone ever reviewed it. Is there someone that would be willing to give some feedback on #9771? |
There seems to be bug with CRA right now, as a temporaray solution, the homepage has been chnaged to . details here: facebook/create-react-app#8813
This is an insidious bug. I was able to resolve this for myself using the following steps:
|
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
Having the same issue! |
Still happening as of today. The |
Describe the bug
I have uploaded all the static resources to CDN, include .js and .css files. So I have to set the 'homepage' as the host address of CDN server, which make the urls of scripts in 'index.html' to be right.
However, the urls injected to 'index.html' is the pathname of 'homepage' that I set in package.json, after upload react-scripts to 3.4.1.
And there is no such problem when I using version 3.3.0. I found that the actual homepage has been change after this PR feat(react-scripts): allow PUBLIC_URL in develoment mode
So I want to know, is it a bug that will be fixed? Or is there any method that can make the PUBLIC_URL to be a complete url.
Did you try recovering your dependencies?
no, but downgrade to 3.3.0
Which terms did you search for in User Guide?
The docs still use the complete url as example Step 1: Add homepage to package.json
Environment
irrelevant, i guess
Steps to reproduce
(Write your steps here:)
Expected behavior
The PUBLIC_URL should be the same as homepage in package.json
Actual behavior
The PUBLIC_URL is the pathname of homepage
Reproducible demo
no demo
The text was updated successfully, but these errors were encountered: