Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies pulled down don't match repo #9418

Closed
reinrl opened this issue Aug 4, 2020 · 7 comments
Closed

Dependencies pulled down don't match repo #9418

reinrl opened this issue Aug 4, 2020 · 7 comments

Comments

@reinrl
Copy link

reinrl commented Aug 4, 2020

It looks like v3.4.1 of react-scripts was last published to NPM four months ago - and so the dependency versions that I get don't match what is currently listed in the latest version of its package.json (e.g., webpack-dev-server 3.10.3 vs. 3.11.0 as an example, which came from this commit, even though package.json in the repo continues to shows 3.4.1 through several pushes). Does a new version need to be published out to npm? I need to take the dependency versions currently listed to get around a noted security vulnerability with webpack-dev-server 3.10.3 (really, with it's dependency on an older version of jquery).

@reinrl
Copy link
Author

reinrl commented Aug 11, 2020

@gaearon or anyone else - any thoughts?

@gaearon
Copy link
Contributor

gaearon commented Aug 11, 2020

I published 3.4.2 earlier today. It won't be in master because that already switched to 4.x

@reinrl
Copy link
Author

reinrl commented Aug 11, 2020

That's exactly what I needed, thank you!

@reinrl reinrl closed this as completed Aug 11, 2020
@ranisalt
Copy link

That is still an issue to me. On a clean container, after running yarn install in a package which requires react-scripts@3.4.3 which pulls webpack-dev-server@3.11.0 I get this:

There might be a problem with the project dependency tree.
It is likely not a bug in Create React App, but something you need to fix locally.

The react-scripts package provided by Create React App requires a dependency:

  "webpack-dev-server": "3.10.3"

Don't try to install it manually: your package manager does it automatically.
However, a different version of webpack-dev-server was detected higher up in the tree:

  /home/rsa/Documents/margot/node_modules/webpack-dev-server (version: 3.11.0)

@gaearon
Copy link
Contributor

gaearon commented Aug 16, 2020

@ranisalt You probably have older react-scripts somewhere in the tree. Try deleting your lockfile and recreating it.

@adrienlo
Copy link

adrienlo commented Aug 28, 2020

I've deleted my lockfile and node_modules but I get this issue as well. I've installed a dependency that uses babel-jest.

I used the latest CRA and my react-scripts is 3.4.3.

The react-scripts package provided by Create React App requires a dependency:

  "babel-jest": "^24.9.0"

Don't try to install it manually: your package manager does it automatically.
However, a different version of babel-jest was detected higher up in the tree:

  /cra/node_modules/babel-jest (version: 25.5.1)
$ npm ls babel-jest
├─┬ @foo/utils@0.0.22
│ └─┬ jest@25.4.0
│   └─┬ @jest/core@25.5.4
│     └─┬ jest-config@25.5.4
│       └── babel-jest@25.5.1
└─┬ react-scripts@3.4.3
  ├── babel-jest@24.9.0
  └─┬ jest@24.9.0
    └─┬ jest-cli@24.9.0
      └─┬ jest-config@24.9.0
        └── babel-jest@24.9.0

Edit
Extra notes: @foo/utils is a custom package that we deploy to npm. babel-jest is a devDependencies.

@gaearon
Copy link
Contributor

gaearon commented Aug 28, 2020

@adrienlo Your question is unrelated to the very specific issue being discussed. I assume people end up here because of the search but it was a very specific question. Feel free to raise a new issue if you think there's a bug.

@facebook facebook locked as resolved and limited conversation to collaborators Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants