Fix wp loaders #1077
Merged
Fix wp loaders #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This may need changes based on issue comments. |
fson
reviewed
Nov 21, 2016
| @@ -21,7 +21,7 @@ module.exports = (resolve, rootDir, isEjecting) => { | |||
| collectCoverageFrom: ['src/**/*.{js,jsx}'], | |||
| moduleFileExtensions: ['jsx', 'js', 'json'], | |||
| moduleNameMapper: { | |||
| '^.+\\.(ico|jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$': resolve('config/jest/FileStub.js'), | |||
| '^.+\\.(?!(js|jsx|css|json|html)$)[^\\.]+$': resolve('config/jest/FileStub.js'), | |||
There was a problem hiding this comment.
The .html extension shouldn't be needed here because importing .html files is not supported.
There was a problem hiding this comment.
ok - if you think this works otherwise I'll just remove the html
There was a problem hiding this comment.
The reason we use moduleNameMapper is just so that imports with these file types get stubbed by Jest, instead of failing because Node.js can't import them. But the only HTML file we handle is index.html, and never imported in code. So yes, it should work.
fson
reviewed
Nov 21, 2016
| @@ -124,6 +124,7 @@ module.exports = { | |||
| // A missing `test` is equivalent to a match. | |||
| { | |||
| exclude: [ | |||
| /\.(html)$/, | |||
There was a problem hiding this comment.
You can omit the parentheses around html.
Revert webpack prod config comments to not refer to dev server.
|
Looks good to me! |
jarlef
pushed a commit
to jarlef/create-react-app
that referenced
this pull request
Nov 28, 2016
Revert webpack prod config comments to not refer to dev server.
fson
added a commit
to fson/create-react-app
that referenced
this pull request
Dec 4, 2016
Jest matches moduleNameMapper regexes with module names, not the full file path, so the negative lookahead doesn’t work for filtering out JS files, because they can be imported without the extension. So paths like `lodash.assign` and `../utils/range` were mislabeled as resources with unknown file extensions because they have a dot in the name. As a stopgap measure, revert the moduleNameMapper regex added in facebook#1077.
fson
added a commit
that referenced
this pull request
Dec 4, 2016
Jest matches moduleNameMapper regexes with module names, not the full file path, so the negative lookahead doesn’t work for filtering out JS files, because they can be imported without the extension. So paths like `lodash.assign` and `../utils/range` were mislabeled as resources with unknown file extensions because they have a dot in the name. As a stopgap measure, revert the moduleNameMapper regex added in #1077.
alexdriaguine
pushed a commit
to alexdriaguine/create-react-app
that referenced
this pull request
Jan 23, 2017
Revert webpack prod config comments to not refer to dev server.
alexdriaguine
pushed a commit
to alexdriaguine/create-react-app
that referenced
this pull request
Jan 23, 2017
Jest matches moduleNameMapper regexes with module names, not the full file path, so the negative lookahead doesn’t work for filtering out JS files, because they can be imported without the extension. So paths like `lodash.assign` and `../utils/range` were mislabeled as resources with unknown file extensions because they have a dot in the name. As a stopgap measure, revert the moduleNameMapper regex added in facebook#1077.
randycoulman
pushed a commit
to CodingZeal/create-react-app
that referenced
this pull request
May 8, 2017
Revert webpack prod config comments to not refer to dev server.
randycoulman
pushed a commit
to CodingZeal/create-react-app
that referenced
this pull request
May 8, 2017
Jest matches moduleNameMapper regexes with module names, not the full file path, so the negative lookahead doesn’t work for filtering out JS files, because they can be imported without the extension. So paths like `lodash.assign` and `../utils/range` were mislabeled as resources with unknown file extensions because they have a dot in the name. As a stopgap measure, revert the moduleNameMapper regex added in facebook#1077.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #667.