Fixed issue where resolve-url-loader would not work on Windows due to CRLF. #11004
Conversation
Fixed issue where resolve-url-loader would not work on Windows. This fixes facebook#8596
lfshr
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @lfshr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@ianschmitz @iansu @mrmckeb @petetnt any chance of a review on this one? |
|
This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs. |
|
Begone Stalebot! |
Fixed issue where resolve-url-loader would not work on Windows due to removeCR not being specified on Windows machines. This fixes #8596
I've been unable to get create-react-app working inside this repo to test (even in WSL), but I have replaced the webpack in an existing project's
node_modules/react-scriptswhich resolved the issues in that project.