Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dependency issue after workbox-webpack-plugin 6.2 release #11292

Merged
merged 2 commits into from Aug 18, 2021
Merged

fix: dependency issue after workbox-webpack-plugin 6.2 release #11292

merged 2 commits into from Aug 18, 2021
+1 −1

Conversation

fguitton
Copy link
Contributor

@fguitton fguitton commented Aug 6, 2021 •
edited

The latest release of workbox-build is not being pulled by react-scripts due to an explicit dependency on workbox-webpack-plugin@6.1.5.

Since there are no breaking changes mentioned in the Workbox releases notes, this PR updated the version to 6.2.0

@fguitton fguitton changed the title [WIP] Fix sub-dependency issue from workbox-webpack-plugin Fix dependency issue after workbox-webpack-plugin release Aug 6, 2021
@fguitton fguitton marked this pull request as ready for review August 6, 2021 10:31
@ryota-murakami
Copy link
Contributor

Nice! This should be merge soon! cc: @raix

@raix raix linked an issue Aug 6, 2021 that may be closed by this pull request
[v5] Workbox webpack plugin current version is broken update to 6.2.0 #11293
Closed
@raix raix added this to the 5.0 milestone Aug 6, 2021
@raix
Copy link
Contributor

raix commented Aug 6, 2021

Thanks @fguitton for the pr.
@iansu / @mrmckeb do we need to run yarn compile:lockfile on dependency updates?

@fguitton fguitton changed the title Fix dependency issue after workbox-webpack-plugin release fix: dependency issue after workbox-webpack-plugin 6.2 release Aug 15, 2021
This was referenced Aug 18, 2021
Closed
Closed
@mrmckeb
Copy link
Contributor

mrmckeb commented Aug 18, 2021

Sorry @raix, missed that comment - no need, that's a part of the release workflow I think.

@iansu iansu merged commit 498c0cf into facebook:main Aug 18, 2021
@iansu
Copy link
Contributor

iansu commented Aug 18, 2021

Thanks!

@fguitton fguitton deleted the fix-deps/workbox-build branch August 18, 2021 18:28
EhsanFortuna pushed a commit to EhsanFortuna/create-react-app that referenced this pull request Aug 23, 2021
@fguitton
fix: dependency issue after workbox-webpack-plugin 6.2 release (faceb…
13f29ad 
…ook#11292)

* fix: Sub-dependency of workbox-webpack-plugin failed to yeild the correct version

* chore: Bump workbox-webpack-plugin to 6.2.4 to address regressions
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
@fguitton @abhiisheek
fix: dependency issue after workbox-webpack-plugin 6.2 release (faceb…
7cb793f 
…ook#11292)

* fix: Sub-dependency of workbox-webpack-plugin failed to yeild the correct version

* chore: Bump workbox-webpack-plugin to 6.2.4 to address regressions
@Omrisnyk Omrisnyk mentioned this pull request Nov 27, 2023
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 12, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmckeb mrmckeb mrmckeb approved these changes

@iansu iansu Awaiting requested review from iansu

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

[v5] Workbox webpack plugin current version is broken update to 6.2.0
6 participants
@fguitton @ryota-murakami @raix @mrmckeb @iansu @facebook-github-bot