Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename setupProxy.js to setupProxy.cjs #11564

Closed
wants to merge 1 commit into from

Conversation

razor-x
Copy link

@razor-x razor-x commented Oct 20, 2021

With the next major version of CRA releasing soon, we have the opportunity to introduce a low-impact breaking change in order to close #8046 (comment):

  • If you use setupProxy.js, rename it to setupProxy.cjs.

This is an alternative to the arguably better but more complicated PR which has been stuck for a while #10228.

@facebook-github-bot
Copy link

Hi @razor-x!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jan 8, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jan 8, 2022
@razor-x
Copy link
Author

razor-x commented Jan 9, 2022

Any way to get a 👍🏻 or 👎🏻 on this idea?

@stale stale bot removed the stale label Jan 9, 2022
@razor-x razor-x closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support setupProxy.mjs
2 participants