Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extract-text-webpack-plugin to stable #1700

Merged
merged 1 commit into from Mar 2, 2017

Conversation

Projects
None yet
5 participants

@SimenB SimenB referenced this pull request Mar 2, 2017

Merged

Upgrade to webpack v2 #1291

7 of 10 tasks complete

@gaearon gaearon added this to the 0.10.0 milestone Mar 2, 2017

@bondz

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2017

Would it check off any of the tasks in #1668?

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Mar 2, 2017

@bondz no, they released extract-text-webpack-plugin as stable before it was stable. 🤷‍♀️

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Mar 2, 2017

Thanks for the update, @SimenB. Have you tested the latest version still works? If not, I can test it tonight. Thanks!

@SimenB

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2017

I have not tested it, no. This is just submitted through the GH UI

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Mar 2, 2017

Eh, it's in master anyway -- I'm sure it's fine. Thanks!
famous last words

@Timer Timer merged commit 45d1d24 into facebook:master Mar 2, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Timer Timer added the tag: internal label Mar 2, 2017

@Timer

This comment has been minimized.

Copy link
Collaborator

commented Mar 2, 2017

Hm, not sure if this should be tagged internal or enhancement or nothing. /cc @gaearon

@gaearon

This comment has been minimized.

Copy link
Member

commented Mar 2, 2017

Internal is fine.

@SimenB SimenB deleted the SimenB:patch-1 branch Mar 2, 2017

kohver added a commit to stockspiking/create-react-app that referenced this pull request Mar 9, 2017

WiNloSt added a commit to prontotools/create-react-app that referenced this pull request Apr 4, 2017

sbuzonas pushed a commit to sbuzonas/react-scripts that referenced this pull request May 5, 2017

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.