Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sw-precache-webpack-plugin to lastest version #2429

Merged
merged 2 commits into from Jun 26, 2017

Conversation

Projects
None yet
3 participants
@goldhand
Copy link
Contributor

commented May 31, 2017

Updating sw-precache-webpack-plugin to v0.11.3 will fix the following related issues:

Windows path: #2235
Duplicate builds: #1728 (comment)

I have tested by running /bin/react-scripts.js build and asserting that the build log message is not emitted twice. The problem was discovered in this goldhand/sw-precache-webpack-plugin#78 we were calling the webpack done callback twice.

I do not have a windows machine to test the windows fix but the fix is exactly the same as in this configuration. The fix is here and has been published for a couple weeks now with no issue.

In addition to these fixes, updating to 0.11.3 will allow chunk's with hashes to be "precached" and used in importScripts.

@facebook-github-bot

This comment has been minimized.

Copy link

commented May 31, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot

This comment has been minimized.

Copy link

commented May 31, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@goldhand goldhand force-pushed the goldhand:master branch from 0766f86 to b11c1f4 Jun 2, 2017

@goldhand goldhand changed the title Update sw-precache-webpack-plugin to v0.11.2 Update sw-precache-webpack-plugin to lastest version Jun 2, 2017

@gaearon gaearon added this to the 1.0.8 milestone Jun 26, 2017

@gaearon gaearon merged commit 3e9955d into facebook:master Jun 26, 2017

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 26, 2017

Looks great. Thanks.

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

Update sw-precache-webpack-plugin to lastest version (facebook#2429)
* Update sw-precache-webpack-plugin to v0.11.3

* Pin the version

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

Update sw-precache-webpack-plugin to lastest version (#2429)
* Update sw-precache-webpack-plugin to v0.11.3

* Pin the version

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

Update sw-precache-webpack-plugin to lastest version (facebook#2429)
* Update sw-precache-webpack-plugin to v0.11.3

* Pin the version

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.