Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack no need for `ident` if using complex options anymore #2430

Merged
merged 1 commit into from Jun 26, 2017

Conversation

Projects
None yet
4 participants
@andykenward
Copy link
Contributor

commented May 31, 2017

Since v2.2.1 of Webpack, the need for ident for complex options is no longer required. See

https://webpack.js.org/guides/migrating/#complex-options

Steps ran to check if postcss-loader and its plugins still work.

  • npm start.
  • Add to App.css.
display: flex;
user-select: none;
flex: 1 0 calc(1vw - 1px);
  • Check chrome dev tools and select element too see if postcss-flexbugs-fixes & autoprefixer work. See screenshot.

react_app_and_luisrudge_postcss-flexbugs-fixes__postcss_plugin_that_tries_to_fix_all_of_flexbug_s_issues

Then checked build version

  • npm run build
  • serve -s build
  • Check chrome dev tools and select element. See screenshot

react_app

webpack no need for `ident` if using complex options anymore
Since `v2.2.1` of webpack the need for `ident` for complex options is no longer required. See

https://webpack.js.org/guides/migrating/#complex-options
@dashed

This comment has been minimized.

Copy link

commented Jun 14, 2017

Can confirm 👍

@gaearon gaearon added this to the 1.0.8 milestone Jun 26, 2017

@gaearon gaearon merged commit 43d0307 into facebook:master Jun 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 26, 2017

Thanks!

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 29, 2017

Seems like this was necessary after all :P
#2677 (comment)

@andykenward

This comment has been minimized.

Copy link
Contributor Author

commented Jun 29, 2017

Ah. Sorry about that @gaearon .

One of the issues with webpack supporting legacy loader configs :(

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 29, 2017

No worries! I'd appreciate if you could dig into why this is still necessary and breaks in this weird way. Maybe there's a bug in one of those packages?

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

webpack no need for `ident` if using complex options anymore (faceboo…
…k#2430)

Since `v2.2.1` of webpack the need for `ident` for complex options is no longer required. See

https://webpack.js.org/guides/migrating/#complex-options

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

webpack no need for `ident` if using complex options anymore (#2430)
Since `v2.2.1` of webpack the need for `ident` for complex options is no longer required. See

https://webpack.js.org/guides/migrating/#complex-options

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

webpack no need for `ident` if using complex options anymore (faceboo…
…k#2430)

Since `v2.2.1` of webpack the need for `ident` for complex options is no longer required. See

https://webpack.js.org/guides/migrating/#complex-options

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.