Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning when trying to run on port below 1024 without admin permissions under Linux/macOS #2518

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
5 participants
@levrik
Copy link
Contributor

commented Jun 11, 2017

On Linux/macOS (and WSL too) it requires admin permissions to run a server on a port below 1024.
I'm shifting my development stuff to WSL on Windows at the moment and didn't know that so it would be nice to show another message in this case.

image

  • Tested on WSL
  • Tested on Linux
  • Tested on macOS (I cannot do this. No Mac.)

ref #2512

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jun 11, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

This comment has been minimized.

Copy link

commented Jun 11, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@levrik levrik changed the title Show warning when trying to run on port below 1024 without admin permissions under Linux Show warning when trying to run on port below 1024 without admin permissions under Linux/macOS Jun 11, 2017

@afontcu

This comment has been minimized.

Copy link

commented Jun 15, 2017

Warning shows up in a Mac (OS X 10.11 with ohmyzsh).

Mac OS port <1024 warning

@levrik

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2017

@afontcu Thank you for testing. PR is ready now.

@trueadm trueadm self-requested a review Jun 19, 2017

@trueadm
Copy link

left a comment

Looks great to me. Thank you for this!

@trueadm trueadm added this to the 1.0.8 milestone Jun 19, 2017

@trueadm trueadm merged commit b1c0faa into facebook:master Jun 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@levrik levrik deleted the levrik:improve-port-warning branch Jun 19, 2017

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 28, 2017

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.