Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix eject command updating scripts output #2562
Hi :) I've a spotted a small bug in eject command output.
"start": "react-scripts start", "build": "react-scripts build", "test": "react-scripts test --env=jsdom", "eject": "react-scripts eject", "stylelint": "node ./node_modules/stylelint/bin/stylelint.js src/**/*.scss", "eslint": "node ./node_modules/eslint/bin/eslint.js src/**/*.js"
As you can see there are two custom scripts that were added after the project was created.
While the updated
"start": "node scripts/start.js", "build": "node scripts/build.js", "test": "node scripts/test.js --env=jsdom", "stylelint": "node ./node_modules/stylelint/bin/stylelint.js src/**/*.scss", "eslint": "node ./node_modules/eslint/bin/eslint.js src/**/*.js"
so those two custom scripts were untouched and it's ok, because they are not related to the Create React App.
I have added a simple check to fix the misleading message. After the fix the output looks like:
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.
If you have received this in error or have any questions, please contact us at email@example.com. Thanks!