Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Brackets to launchEditor.js #2637

Merged
merged 1 commit into from Jun 27, 2017

Conversation

Projects
None yet
3 participants
@petetnt
Copy link
Collaborator

commented Jun 27, 2017

Hello from the https://github.com/adobe/brackets/ team! 馃憢

Tested on MacOS, should work on WIN too!

@gaearon gaearon added this to the 1.0.8 milestone Jun 27, 2017

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

Hmm. I think we'll hold off until this is implemented:

https://trello.com/c/ikTpxs58/1424-ability-to-browse-to-a-specific-line-in-a-file-using-command-line

All other editors we autodetect can do this.

@gaearon gaearon modified the milestones: 1.x, 1.0.8 Jun 27, 2017

@petetnt

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 27, 2017

Hi @gaearon,

not sure why that ticket is in the Icebox (well I do as the Trello has been been quite mismanaged for a long while as many of the current contributors don't have access...) but Brackets does open the file in the correct line/file automatically (just re-confirmed it on my own computer).

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

Hmm. Correct line didn't work for me on Windows. Maybe Windows version has different CLI arguments?

@petetnt

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 27, 2017

Could duplicate the correct line part on Windows too myself, not quite sure why the MacOS version manages to open the correct part anyway without the mapping here anyway: https://github.com/petetnt/create-react-app/blob/dca50a5c3b83e1be4a9c08c63c0a4ac405e1434a/packages/react-dev-utils/launchEditor.js#L55-L95 馃 馃

We do handle the linenumber in the format of fullpath:linenumber as seen here https://github.com/adobe/brackets/blob/master/src/document/DocumentCommandHandlers.js#L417-L440 like many other editors, but for some reason it does not work at all when launching from command line on Windows. I'll get to the bottom of this ASAP 馃憤

@gaearon

This comment has been minimized.

Copy link
Member

commented Jun 27, 2017

Thanks for looking! I'll get merged then, but hope this gets fixed.

@gaearon gaearon modified the milestones: 1.0.8, 1.x Jun 27, 2017

@gaearon gaearon merged commit 84299ce into facebook:master Jun 27, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request Jun 28, 2017

Merge branch 'master' into serve-app-under
* master: (59 commits)
  Better React Native Web support (facebook#2511)
  Bump dependencies (facebook#2658)
  Minor code style edits to user guide (facebook#2660)
  Don't ask to install webpack for using Styleguidist (facebook#2656)
  Put react-scripts in dependencies, not devDependencies (facebook#2657)
  Razzle added to the alternatives (facebook#2517)
  Warn about large bundle sizes (facebook#2648)
  Add instructions to use source-map-explorer (facebook#1641)
  Ignore "Skipping static resource" message from SW precache (facebook#2645)
  Add React Styleguidist (facebook#2044)
  Update ISSUE_TEMPLATE.md (facebook#2643)
  Add Brackets to launchEditor.js (facebook#2637)
  Updated README (facebook#1931)
  Less passive-aggressive issue template
  Added instruction on how to install Prettier (facebook#2006)
  Fix CLI grammar (facebook#1945)
  Update README.md (facebook#1813)
  Add more info about OOM build failiure [docs] (facebook#2060)
  Update docs with WebSocket proxy information (facebook#2305)
  Add yarn example under "Installing a Dependency" (facebook#2362)
  ...

@gaearon gaearon referenced this pull request Jun 28, 2017

Merged

Changelog for 1.0.8 #2664

romaindso added a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017

wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can鈥檛 perform that action at this time.