Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder vim arguments in launchEditor so --remote works #2723

Merged
merged 1 commit into from
Jul 4, 2017

Commits on Jul 4, 2017

  1. Reorder vim arguments in launchEditor so --remote works

    This allows you to set REACT_EDITOR to 'vim --remote', so the file can
    be opened in an already running vim process. When using vim without
    remote, it works in the same way as before.
    
    When launching vim without --remote, the order of the line and path
    arguments doesn't matter. However, when using --remote the line argument
    has to precede the path. This happens to be the same as joe and emacs
    uses, so the vim cases were just moved there.
    
    I haven't tested this with mvim, but the documentation says the same as
    the vim documentation, so I assume it works the same.
    trygveaa committed Jul 4, 2017
    Configuration menu
    Copy the full SHA
    b8d1c78 View commit details
    Browse the repository at this point in the history