Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit "Opting Out of Caching" header #2822

Merged
merged 1 commit into from Jul 19, 2017

Conversation

Projects
None yet
4 participants
@gaearon
Copy link
Member

commented Jul 19, 2017

So that it's harder to miss.

@gaearon gaearon added this to the 1.0.11 milestone Jul 19, 2017

@gaearon gaearon merged commit d679843 into master Jul 19, 2017

@@ -1571,7 +1574,8 @@ have decided that you would like to disable them for all your existing users,
you can swap out the call to `serviceWorkerRegistration.register()` in
[`src/index.js`](src/index.js) with a call to `serviceWorkerRegistration.unregister()`.
After the user visits a page that has `serviceWorkerRegistration.unregister()`,
the service worker will be uninstalled.
the service worker will be uninstalled. Note that depending on how `/service-worker.js` is served,
it make take up to 24 hours for the cache to be invalidated.

This comment has been minimized.

Copy link
@powah

powah Aug 9, 2017

Should be may instead of make

This comment has been minimized.

Copy link
@Timer

Timer Aug 9, 2017

Collaborator

Feel free to submit a PR. 😄

This comment has been minimized.

Copy link
@Timer

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Aug 9, 2017

@Timer Timer deleted the gaearon-patch-20 branch Aug 9, 2017

morgs32 added a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017

JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017

kasperpeulen added a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017

swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.