Add explicit "Opting Out of Caching" header #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powah
reviewed
Aug 9, 2017
| @@ -1571,7 +1574,8 @@ have decided that you would like to disable them for all your existing users, | |||
| you can swap out the call to `serviceWorkerRegistration.register()` in | |||
| [`src/index.js`](src/index.js) with a call to `serviceWorkerRegistration.unregister()`. | |||
| After the user visits a page that has `serviceWorkerRegistration.unregister()`, | |||
| the service worker will be uninstalled. | |||
| the service worker will be uninstalled. Note that depending on how `/service-worker.js` is served, | |||
| it make take up to 24 hours for the cache to be invalidated. | |||
JohnNilsson
referenced
this pull request
in JohnNilsson/create-react-app-typescript
Aug 9, 2017
morgs32
pushed a commit
to BrickworkSoftware/create-react-app
that referenced
this pull request
Sep 1, 2017
JohnNilsson
referenced
this pull request
in JohnNilsson/create-react-app-typescript
Sep 9, 2017
kasperpeulen
pushed a commit
to kasperpeulen/create-react-app
that referenced
this pull request
Sep 24, 2017
swengorschewski
referenced
this pull request
in swengorschewski/cra-typescript-electron
Oct 16, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that it's harder to miss.