Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install React Bootstrap Dependency - section added #313

Merged
merged 3 commits into from
Aug 1, 2016

Conversation

manavsehgal
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Aug 1, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@ghost ghost added the CLA Signed label Aug 1, 2016
@ghost
Copy link

ghost commented Aug 1, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon
Copy link
Contributor

gaearon commented Aug 1, 2016

This makes it sound a little like we officially recommend or require it. Can you remove "dependency" from the title and add a short intro explaining that it is not required for React but it is fairly popular so we provided some instructions?

@manavsehgal
Copy link
Contributor Author

@gaearon makes sense. Done the intro and clarification as suggested.

@ghost ghost added the CLA Signed label Aug 1, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 1, 2016

This looks very good, let’s just move this after Add Images and Fonts.

@manavsehgal
Copy link
Contributor Author

Done.

@gaearon gaearon merged commit d5081f3 into facebook:master Aug 1, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 1, 2016

Thanks. If you'd like, I'd appreciate another PR that adds a table of contents to that README (since it's getting quite long).

@manavsehgal
Copy link
Contributor Author

Will give it a go...

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants