Better documentation for setupTests.js when ejecting #3656
Conversation
When running `npm run eject` before creating `src/setupTests.js`, the resulting `package.json` file, won't contain any entry for it - and this is correct in my opinion, since otherwise Jest will crash - but it's useful to have it documented and avoid pointless waste of time.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Documented via 1c8a7f3. Thanks! |
|
Ooh this is actually better than what I did. I didn’t look at the PR because it wasn’t linked to the issue. |
|
Hi @gaearon , thank you! |
|
Ah, I see! Sorry, we generally don't read closed issues because there's just way too much information (it took me 10 hours yesterday to go through just the open ones). |
|
@dannycalleri I like your wording, do you think you could update this to find a middle ground between what you and what I did? Whatever makes most sense to you (I'm fine with deleting my wording, although I'd like to leave the mention in more than one place). |
Added another note about src/setupTests.js and `npm run eject` in Testing Components section
|
Sure @gaearon , I already modified the README with another note in the same place as yours but using an anchor to the other, just to avoid repeating the code sample. |
|
(Please rebase on top of master) |
|
Sorry @gaearon , I instinctively merged master in seeing the conflict, then I read your comment. How do you want to proceed? |
|
This looks good, thanks |
|
Thank you @gaearon . Would love to help with other issues, can you point me to some other stuff? |
|
It's a bit tricky because the repo is in a messy state: there's a bunch of different things we want to do and we haven't had time to address them properly. Keep tabs on #3672, we'll likely mention some next TODOs there. |
* Better documentation for setupTests.js when ejecting When running `npm run eject` before creating `src/setupTests.js`, the resulting `package.json` file, won't contain any entry for it - and this is correct in my opinion, since otherwise Jest will crash - but it's useful to have it documented and avoid pointless waste of time. * Added additional note about src/setupTests.js Added another note about src/setupTests.js and `npm run eject` in Testing Components section * Update README.md * Update README.md
* Better documentation for setupTests.js when ejecting When running `npm run eject` before creating `src/setupTests.js`, the resulting `package.json` file, won't contain any entry for it - and this is correct in my opinion, since otherwise Jest will crash - but it's useful to have it documented and avoid pointless waste of time. * Added additional note about src/setupTests.js Added another note about src/setupTests.js and `npm run eject` in Testing Components section * Update README.md * Update README.md
When running
npm run ejectbefore creatingsrc/setupTests.js, the resultingpackage.jsonfile, won't contain any entry for it - and this is correct in my opinion, since otherwise Jest will crash - but it's useful to have it documented and avoid pointless waste of time.