Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend --scripts-version to include .tar.gz format #3725

Merged
merged 2 commits into from Jan 9, 2018

Conversation

Projects
None yet
3 participants
@SaschaDens
Copy link
Contributor

SaschaDens commented Jan 9, 2018

Closes #3573

Added a minor change to allow .tar.gz extension for the --scripts-version CLI.
I didn't enable the .tar extension, It's supported by the package(tar-pack) but it seems not to be supported by Yarn.

Thanks!

@@ -487,6 +492,7 @@ function checkNodeVersion(packageName) {
packageName,
'package.json'
);
console.log(packageJsonPath);

This comment has been minimized.

Copy link
@gaearon

This comment has been minimized.

Copy link
@SaschaDens

SaschaDens Jan 9, 2018

Author Contributor

Oops indeed, overlooked this one.

@gaearon gaearon merged commit 11f09a1 into facebook:master Jan 9, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gaearon gaearon added this to the 1.0.18 milestone Jan 9, 2018

@gaearon gaearon referenced this pull request Jan 15, 2018

Merged

Changelog for 1.1.0 #3795

tabrindle added a commit to tabrindle/create-react-app that referenced this pull request Jan 18, 2018

Extend --scripts-version to include .tar.gz format (facebook#3725)
* Extend --scripts-version to include .tar.gz format

* Removal of debug console.log

Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018

Extend --scripts-version to include .tar.gz format (facebook#3725)
* Extend --scripts-version to include .tar.gz format

* Removal of debug console.log

mrmckeb pushed a commit to mrmckeb/create-react-app that referenced this pull request Nov 6, 2018

Extend --scripts-version to include .tar.gz format (facebook#3725)
* Extend --scripts-version to include .tar.gz format

* Removal of debug console.log

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.