Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use private registry #3744

Merged
merged 3 commits into from Jan 11, 2018

Conversation

Projects
None yet
3 participants
@Timer
Copy link
Collaborator

Timer commented Jan 11, 2018

This removes a lot of the painful trickery we do via setting up a local registry and actually publishes the modules.

We can now test as if we're an end-user. This means our tests actually mean something now. 馃槃

verdaccio is used to spin up a lightweight local registry. It allows you to publish packages and uses npm as its fallback.
verdaccio supports an anonymous publishing mode, but I'd rather not ship a config file with this.
Since we use verdaccio's defaults, you must login to publish a package.

Due to long standing npm issue, we have to use npm-cli-login to login (over standard npm adduser).

Packages are released using our release.sh script.

The create_react_app function, our install_package npm link workaround, and npm pack of react-scripts are all gone 馃帀.

In hindsight, I can't believe we ever did it different than this. Seriously.

@Timer Timer force-pushed the Timer:ci-registry branch from 3990012 to 91642f4 Jan 11, 2018

@Timer Timer added this to the 1.0.18 milestone Jan 11, 2018

@Timer Timer added the tag: internal label Jan 11, 2018

@Timer Timer merged commit 75d71e1 into facebook:master Jan 11, 2018

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@Timer Timer deleted the Timer:ci-registry branch Jan 11, 2018

@gaearon gaearon referenced this pull request Jan 15, 2018

Merged

Changelog for 1.1.0 #3795

tabrindle added a commit to tabrindle/create-react-app that referenced this pull request Jan 18, 2018

Use private registry (facebook#3744)
* Run e2e-simple in a realistic scenario

* Use npx for everything

* oops
@ORESoftware

This comment has been minimized.

Copy link

ORESoftware commented May 7, 2018

include a link to verdaccio? google is broken for me right now

Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018

Use private registry (facebook#3744)
* Run e2e-simple in a realistic scenario

* Use npx for everything

* oops

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can鈥檛 perform that action at this time.