Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include destructuring transform #3788

Merged
merged 2 commits into from Jan 14, 2018

Conversation

@gaearon
Copy link
Member

commented Jan 14, 2018

This works around #3694 and hardens the integration test for it.

The underlying issue is babel/babel#7215 (comment).

@gaearon gaearon added this to the 1.0.18 milestone Jan 14, 2018

@gaearon

This comment has been minimized.

Copy link
Member Author

commented Jan 14, 2018

If this passes e2e we'll also need to port this to next branch.

@gaearon gaearon merged commit 22f9fe0 into master Jan 14, 2018

0 of 4 checks passed

continuous-integration/appveyor/branch Waiting for AppVeyor build to complete
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@Timer Timer deleted the work-around-babel-bug branch Jan 14, 2018

@gaearon gaearon referenced this pull request Jan 15, 2018
tabrindle added a commit to tabrindle/create-react-app that referenced this pull request Jan 18, 2018
Always include destructuring transform (facebook#3788)
* Always include destructuring transform

* Fix lint
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
Always include destructuring transform (facebook#3788)
* Always include destructuring transform

* Fix lint
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Aug 14, 2018
Always include destructuring transform (facebook#3788)
* Always include destructuring transform

* Fix lint

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.