Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a root path in webpack to resolve long relative path imports #389

Closed
wants to merge 1 commit into from
Closed

Conversation

HarveyAtwal
Copy link

@HarveyAtwal HarveyAtwal commented Aug 7, 2016

Here is my pull request for #388

Test Plan:
This solved relative path issues in my deeply nested folder structure as well as the create-react-app template folder.

This change does not disrupt imported node modules or existing relative paths

These node commands are in good standing:
npm start
npm test
npm run build

Cheers :)

@ghost ghost added the CLA Signed label Aug 7, 2016
@gaearon
Copy link
Contributor

gaearon commented Aug 7, 2016

Please see #253 for a discussion: we would like to use NODE_PATH for this rather than hardcode the ability to do absolute imports. In general this being “on” by default will be confusing. I have seen people severely tripped by trying to create a redux folder in a project that had a redux dependency, and get the wrong import as a result. I’m not convinced this is a good default.

@gaearon gaearon closed this Aug 7, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants