Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e:docker script #4454

Merged
merged 6 commits into from May 14, 2018
Merged

Fix e2e:docker script #4454

merged 6 commits into from May 14, 2018

Conversation

bugzpodder
Copy link

@bugzpodder bugzpodder commented May 13, 2018

yarn e2e:docker works locally with this change. Tested before after, before test fails at yarn publish. After yarn publish works as expected.
Checking CI builds.

@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email cla@fb.com with your details so we can update your status.

verdaccio.yaml Outdated
@@ -0,0 +1,49 @@
#
# This is the default config file. It allows all users to do anything,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this to tasks?

@gaearon gaearon merged commit c2aa163 into facebook:next May 14, 2018
@gaearon
Copy link
Contributor

gaearon commented May 14, 2018

Thanks!

@iansu
Copy link
Contributor

iansu commented May 14, 2018

Did CI pass with these changes?

@bugzpodder
Copy link
Author

bugzpodder commented May 14, 2018

@gaearon
Copy link
Contributor

gaearon commented May 14, 2018

Does CI even use this script? I thought it didn't.

@gaearon
Copy link
Contributor

gaearon commented May 14, 2018

(Travis definitely passed, AppVeyor was failing during yarn fetch which was a common transient issue before so I ignored it)

@bugzpodder
Copy link
Author

I ended up reverting the change in e2e-installs because running it locally was also failing at the same line. But alas I ran it now (after adding back the change) and it just passed.

The CIs were indeed using the e2e-*.sh scripts
https://github.com/facebook/create-react-app/blob/next/appveyor.yml#L45

@gaearon
Copy link
Contributor

gaearon commented May 14, 2018

Sorry, I got confused by description because I thought it's only relevant to docker script. Never mind me 😛

@iansu
Copy link
Contributor

iansu commented May 14, 2018

Thanks for the info guys. Our tests have been a bit flakey lately so I just wanted to make sure we were in a good state after these changes.

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants