Jest 23 and tests #4550
Merged
Jest 23 and tests #4550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 1, 2018 23:10
added 19 commits
June 9, 2018 13:53
|
I would love to see this PR merged. |
Merged
This was referenced Aug 20, 2018
|
Can you please bring this up to date? I want to merge it before v2 releases. |
|
Sounds good, will give it another shot! |
|
Nice. Thanks. |
zmitry
pushed a commit
to zmitry/create-react-app
that referenced
this pull request
Sep 30, 2018
* convert mocha tests to jest * jest 23 * add jest configs * use material css * fix windows * forceExit jest test * force exit eject * test * test * retrigger test * remove appveyor comment * try to remove pretendToBeVisual option * use jsdom env * test environment * no cache * test no close * bring back raf * test revert all broken changes * add back jsdom * remove jsdom * node test environment * use latest change * runInBand * runInBand * comment test run * try different jest option * standardize jest test options * increase heap size * remove heap size config * support scoped packages for cra --scripts-version option * upgrade jest version * fix windows * fix windows again * jest 23.4.1 * babel-jest * babel-jest * split out kitchhensink * travis node 6 * travis node 6 config * node 6 travis eject * cache yarn * only cache yarn * remove unrelated changes * typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gonna see if jest tests work now: #2294
Upgrade to jest 23
Convert mocha tests to jest via #2316
Changed CSS test because of a JSDOM parsing issue (it couldn't handle the entire bootstrap css)
integration config was added because after ejecting jest would have its own config in package.json and I need to override it via --config.
tranformIgnorePatterns change is due to jestjs/jest#6385
Note: jestjs/jest#6523
'[/\\\\\\\\]node_modules[/\\\\\\\\].+\\.(js|jsx|mjs)$'.replace(/(\/|(.)?\\(?![[\]{}()*+?.^$|\\]))/g, (_match, p1, p2) => (p2 && p2 !== '\\' ? p2 + '\\\\' : '\\\\')) === '[/\\\\]node_modules[/\\\\].+\\.(js|jsx|mjs)$'.replace(/(\/|\\(?!\.))/g, '\\\\');blocked by jestjs/jest#6546