Switch from uglify-es to terser #4852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
How can we cleanup terserOptions? |
prichodko
force-pushed
the
feat/switch-to-terser
branch
2 times, most recently
from
f41e601
to
23e3c0d
Compare
prichodko
force-pushed
the
feat/switch-to-terser
branch
from
23e3c0d
to
373b43b
Compare
|
Closing in favour of #4852. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently a terser-webpack-plugin was released and based on a fact that
uglify-esis no longer maintained and issues like #4711 and probably couple of more https://github.com/facebook/create-react-app/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+uglify+, I am opening this PR to start a potential discussion of moving toterser.Terser retains API compatibility with
uglify-es, so I just updated necessarypackage.jsonandwebpack.configfiles and didn't touch any options, however I am curious if this optionhttps://github.com/facebook/create-react-app/blob/next/packages/react-scripts/config/webpack.config.prod.js#L132
could be fixed by migration.
Closes #4711 and potentially more.