Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local development paths #52

Merged
merged 1 commit into from Jul 21, 2016
Merged

Fix local development paths #52

merged 1 commit into from Jul 21, 2016

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jul 21, 2016

Local npm start and npm run build got broken by #33.

@eanplatter FYI — it’s a little confusing but we also support running npm start and npm run build from repo root for fast tweaking of project configuration.

Local npm start and npm run build got broken by #33
@ghost ghost added the CLA Signed label Jul 21, 2016
@gaearon gaearon merged commit e563b20 into master Jul 21, 2016
@eanplatter
Copy link
Contributor

Oh dang, apologies! Is there a way to have the e2e test catch this in the future?

@gaearon
Copy link
Contributor Author

gaearon commented Jul 21, 2016

Yeah, we should add that to e2e.

@mxstbr mxstbr mentioned this pull request Jul 21, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants