New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options to allow for overrides to workbox-webpack-plugin #5369

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
@mymattcarroll
Copy link

mymattcarroll commented Oct 9, 2018

Closes #5359

Verified by:

  1. Running yarn build in create-react-app root and ensuring service worker uses options return by workbox.config.js
@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Oct 9, 2018

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@mymattcarroll

This comment has been minimized.

Copy link

mymattcarroll commented Oct 9, 2018

Still a WIP at the moment, have not verified the changes are working yet. Just looking for some validation on approach right now.

@facebook-github-bot

This comment has been minimized.

Copy link

facebook-github-bot commented Oct 9, 2018

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mymattcarroll

This comment has been minimized.

Copy link

mymattcarroll commented Oct 11, 2018

@Timer, I not sure what has caused the AppVeyor build to fail?

I can see in the logs that a file is being imported from outside of the ./src directory:

You attempted to import ../sample which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.

However, I can see that same error message in the Travis build and it is passing?

@mymattcarroll mymattcarroll force-pushed the mymattcarroll:master branch 3 times, most recently from 42be558 to d4a6576 Oct 26, 2018

@iansu

iansu approved these changes Nov 2, 2018

@Nick-t-go

This comment has been minimized.

Copy link

Nick-t-go commented Nov 2, 2018

Been looking for this update... So confused how workbox was added b/c it is deemed the superior way to configure a PWA, but we have no ability to edit the Workbox webpack plugin that is being used, or do we?

@thelastnode

This comment has been minimized.

Copy link

thelastnode commented Nov 6, 2018

This is great, this is the final piece (set skipWaiting: true) that would allow us to move from react-scripts-ts to vanilla create-react-app!

Is there anything pending on this PR that I can help with? Would love to have this merged for the next release.

@mymattcarroll mymattcarroll force-pushed the mymattcarroll:master branch from b0b1387 to 4e931c2 Nov 14, 2018

@seanmheff

This comment has been minimized.

Copy link

seanmheff commented Nov 26, 2018

Looking forward to this getting merged. I am also looking forward to being able to set the skipWaiting: true option.

@imranismail

This comment has been minimized.

Copy link

imranismail commented Nov 26, 2018

This is the only show stopper for us as well. Looking forward to this merge. Can't stress how important skipWaiting is for UX.

@mymattcarroll mymattcarroll force-pushed the mymattcarroll:master branch from 4e931c2 to 5ab5e77 Nov 29, 2018

@dstapleton92

This comment has been minimized.

Copy link

dstapleton92 commented Dec 5, 2018

Really looking forward to this change as well! What's the status here? Does it need anymore work? If so, I'd be happy to help pitch in.

Does anyone know why the tests are failing?

@mymattcarroll

This comment has been minimized.

Copy link

mymattcarroll commented Dec 5, 2018

@dstapleton92, I have not had the time to investigate the tests that are failing, other than AppVeyor seems to be failing on master last time I checked. I would appreciate any assistance you can supply 😄.

@Timer Timer added this to the 2.x milestone Dec 6, 2018

@dstapleton92

This comment has been minimized.

Copy link

dstapleton92 commented Dec 14, 2018

@mymattcarroll Yeah I see that. Doesn't look like it's from a change you introduced. Anyone have any ideas?

@mymattcarroll

This comment has been minimized.

Copy link

mymattcarroll commented Jan 9, 2019

@dstapleton92 seems a merge with the latest master code has fixed the broken tests. :)

@Timer any chance you could take another look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment