Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webpack-bundle-analyzer #6477

Merged
merged 6 commits into from Mar 19, 2019
Merged

remove webpack-bundle-analyzer #6477

merged 6 commits into from Mar 19, 2019

Conversation

bugzpodder
Copy link

#6438 allows source-map-explorer to analyze bundles with multiple files, which was one of the main features that webpack-bundle-analyzer did better. Now we have less need to have two different ways of analyzing bundle size.

Copy link
Contributor

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the variable, too (writeStatsJson).

@Timer
Copy link
Contributor

Timer commented Feb 21, 2019

I dunno if this needs to be breaking, but I guess it doesn't hurt (this was a secret feature never documented).

@bugzpodder bugzpodder added this to the 3.0 milestone Mar 18, 2019
@bugzpodder bugzpodder added this to In progress in v3 via automation Mar 18, 2019
@bugzpodder bugzpodder merged commit 4a4d2ef into facebook:master Mar 19, 2019
v3 automation moved this from In progress to Done Mar 19, 2019
@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v3
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants