Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terser-webpack-plugin hanging on WSL #6732

Merged
merged 3 commits into from Apr 5, 2019

Conversation

@endiliey
Copy link
Contributor

commented Mar 31, 2019

Motivation

Fix #6723

When running react-scripts build on Windows Subsystem for Linux, the webpack build will hang during the uglifying step. This is caused due to a bug on terser not being able to run in parallel on WSL
(webpack-contrib/terser-webpack-plugin#21)

This PR attempts to disable parallel run on WSL until that bug is fixed upstream

@iansu iansu self-assigned this Mar 31, 2019

@iansu iansu added the tag: bug fix label Mar 31, 2019

@iansu iansu added this to In progress in v3 via automation Mar 31, 2019

@iansu iansu added this to the 3.0 milestone Mar 31, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Apr 4, 2019

Please resolve merge conflicts.

@endiliey

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

@iansu seems that a kind hearted @bugzpodder has done that. Thank you 👍

@iansu iansu merged commit 3e336d9 into facebook:master Apr 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/create-react-app/deploy-preview Docs deploy preview succeeded
Details

v3 automation moved this from In progress to Done Apr 5, 2019

@iansu

This comment has been minimized.

Copy link
Collaborator

commented Apr 5, 2019

Thanks!

@lock lock bot locked and limited conversation to collaborators Apr 10, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.