Use correct babel transform for dynamic import in dependencies #7208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `babel-plugin-transform-dynamic-import` package is not specified in babel-preset-react-app's `package.json`. It appears that it was switched out with `babel-plugin-dynamic-import-node` in `create.js` here: facebook@52fcb23 This commit updates it in `dependencies.js` too.
jamesknelson
requested review from
amyrlam,
bugzpodder,
gaearon,
ianschmitz,
iansu,
mrmckeb,
petetnt and
Timer
as code owners
|
Good catch. Thanks! |
jadurani
pushed a commit
to TuringEnterprises/create-react-app
that referenced
this pull request
Jun 15, 2019
GeekOnCoffee
pushed a commit
to headwayio/create-react-app
that referenced
this pull request
Jun 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
babel-plugin-transform-dynamic-importpackage is not specified in babel-preset-react-app'spackage.json. It appears that it was switched out withbabel-plugin-dynamic-import-nodeincreate.jshere:52fcb23
This commit updates it in
dependencies.jstoo.I ran into this while working on my SSR fork. The build script was failing before this commit, but is works correctly after the switch.