Fix dependency issue #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Waiting for travis this time before merging :)) |
|
Wise man :) |
|
I was able to reproduce locally, and the e2e test worked locally after this change. So my hopes are high! |
|
Yeah, this change looks good. |
|
❤️ e2e |
nwolverson
pushed a commit
to nwolverson/create-react-app
that referenced
this pull request
Jun 29, 2017
fix(typescriptTransform): Let tsc read the config instead of using 'require'
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vjeux my last PR is failing travis, had to move the
fs-extradependency.