Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setupTestFrameworkScriptFile is deprecated #8390

Merged
merged 2 commits into from
Jan 31, 2020
Merged

setupTestFrameworkScriptFile is deprecated #8390

merged 2 commits into from
Jan 31, 2020

Conversation

JimmyLv
Copy link
Contributor

@JimmyLv JimmyLv commented Jan 29, 2020 •
edited
Loading

Note: setupTestFrameworkScriptFile is deprecated in favor of setupFilesAfterEnv.

ref: https://jestjs.io/docs/en/configuration#setupfilesafterenv-array

@JimmyLv
setupTestFrameworkScriptFile is deprecated
7c26a9f 
__Note:_ `_setupTestFrameworkScriptFile_` _is deprecated in favor of_ `_setupFilesAfterEnv_`_.__

ref: https://jestjs.io/docs/en/configuration#setupfilesafterenv-array
@facebook-github-bot
Copy link

Hi JimmyLv! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@amyrlam
Copy link
Contributor

amyrlam commented Jan 29, 2020

@JimmyLv Thanks for including the reference link! Looks good 👍, please sign the CLA.

@amyrlam amyrlam self-assigned this Jan 30, 2020
@andriijas andriijas added this to the 3.4 milestone Jan 31, 2020
@JimmyLv @SimenB
Update docusaurus/docs/running-tests.md
8a2c345 
Co-Authored-By: Simen Bekkhus <sbekkhus91@gmail.com>
@JimmyLv
Copy link
Contributor Author

JimmyLv commented Jan 31, 2020

@amyrlam Yes, and I already signed the CLA.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@andriijas andriijas merged commit 0db04ec into facebook:master Jan 31, 2020
@lock lock bot locked and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB left review comments

@awibox awibox awibox approved these changes

@ianschmitz ianschmitz ianschmitz approved these changes

@amyrlam amyrlam Awaiting requested review from amyrlam

@iansu iansu Awaiting requested review from iansu

Assignees

@amyrlam amyrlam

Labels
CLA Signed tag: documentation
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JimmyLv @facebook-github-bot @amyrlam @SimenB @awibox @ianschmitz @andriijas