Bump typescript template to 3.8 #8713
Conversation
braedongough
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
|
Hi @braedongough! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I don't think that the problem comes from typescript but from PrettyFormat |
|
@getspooky The issue is PrettyFormat uses a feature only available in TS3.8 (type imports). It's not invalid code for that version, but CRA is locked to an older version. |
There was a problem hiding this comment.
This makes sense to me - but perhaps leave it as a carrot range @braedongough? "^3.8.0"
Can do! |
|
I noticed this problem yesterday too, would love for this PR to go through! 👏 |
Description
It looks like @testing-library dependency currently relies on type-only imports which conflicts with the version of Typescript used in the cra template, preventing it from building straight after starting a new project.